[PHASE-7] Remove validation from message decoder

This commit is contained in:
Savely Krendelhoff 2025-08-23 13:08:06 +07:00
parent 2c8d6c828f
commit 8aa5b91f24
No known key found for this signature in database
GPG key ID: F70DFD34F40238DE
2 changed files with 0 additions and 25 deletions

View file

@ -25,11 +25,6 @@ func (d *MessageDecoder) Decode(r io.Reader) (*Message, error) {
return nil, fmt.Errorf("failed to read message type: %w", err)
}
// Validate message type (only request types are valid for server)
if !isValidRequestType(msgType) {
return nil, fmt.Errorf("invalid message type: 0x%02x", msgType)
}
// Read payload length (4 bytes, big-endian)
var payloadLength uint32
if err := binary.Read(r, binary.BigEndian, &payloadLength); err != nil {
@ -53,13 +48,3 @@ func (d *MessageDecoder) Decode(r io.Reader) (*Message, error) {
PayloadStream: payloadStream,
}, nil
}
// isValidRequestType checks if the message type is a valid request type
func isValidRequestType(msgType MessageType) bool {
switch msgType {
case ChallengeRequestType, SolutionRequestType:
return true
default:
return false
}
}

View file

@ -70,16 +70,6 @@ func TestMessageDecoder_Decode_Errors(t *testing.T) {
data: []byte{},
wantErr: "EOF",
},
{
name: "invalid message type",
data: []byte{0xFF, 0x00, 0x00, 0x00, 0x00},
wantErr: "invalid message type",
},
{
name: "response type not allowed",
data: []byte{0x02, 0x00, 0x00, 0x00, 0x00}, // ChallengeResponseType
wantErr: "invalid message type",
},
{
name: "incomplete header",
data: []byte{0x01, 0x00, 0x00},