[PHASE-7] Remove validation from message decoder
This commit is contained in:
parent
2c8d6c828f
commit
8aa5b91f24
|
|
@ -25,11 +25,6 @@ func (d *MessageDecoder) Decode(r io.Reader) (*Message, error) {
|
||||||
return nil, fmt.Errorf("failed to read message type: %w", err)
|
return nil, fmt.Errorf("failed to read message type: %w", err)
|
||||||
}
|
}
|
||||||
|
|
||||||
// Validate message type (only request types are valid for server)
|
|
||||||
if !isValidRequestType(msgType) {
|
|
||||||
return nil, fmt.Errorf("invalid message type: 0x%02x", msgType)
|
|
||||||
}
|
|
||||||
|
|
||||||
// Read payload length (4 bytes, big-endian)
|
// Read payload length (4 bytes, big-endian)
|
||||||
var payloadLength uint32
|
var payloadLength uint32
|
||||||
if err := binary.Read(r, binary.BigEndian, &payloadLength); err != nil {
|
if err := binary.Read(r, binary.BigEndian, &payloadLength); err != nil {
|
||||||
|
|
@ -53,13 +48,3 @@ func (d *MessageDecoder) Decode(r io.Reader) (*Message, error) {
|
||||||
PayloadStream: payloadStream,
|
PayloadStream: payloadStream,
|
||||||
}, nil
|
}, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
// isValidRequestType checks if the message type is a valid request type
|
|
||||||
func isValidRequestType(msgType MessageType) bool {
|
|
||||||
switch msgType {
|
|
||||||
case ChallengeRequestType, SolutionRequestType:
|
|
||||||
return true
|
|
||||||
default:
|
|
||||||
return false
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
|
||||||
|
|
@ -70,16 +70,6 @@ func TestMessageDecoder_Decode_Errors(t *testing.T) {
|
||||||
data: []byte{},
|
data: []byte{},
|
||||||
wantErr: "EOF",
|
wantErr: "EOF",
|
||||||
},
|
},
|
||||||
{
|
|
||||||
name: "invalid message type",
|
|
||||||
data: []byte{0xFF, 0x00, 0x00, 0x00, 0x00},
|
|
||||||
wantErr: "invalid message type",
|
|
||||||
},
|
|
||||||
{
|
|
||||||
name: "response type not allowed",
|
|
||||||
data: []byte{0x02, 0x00, 0x00, 0x00, 0x00}, // ChallengeResponseType
|
|
||||||
wantErr: "invalid message type",
|
|
||||||
},
|
|
||||||
{
|
{
|
||||||
name: "incomplete header",
|
name: "incomplete header",
|
||||||
data: []byte{0x01, 0x00, 0x00},
|
data: []byte{0x01, 0x00, 0x00},
|
||||||
|
|
|
||||||
Loading…
Reference in a new issue